[python] Fix registration path with non-standard obs/var index names #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
===========================================
+ Coverage 78.86% 90.94% +12.08%
===========================================
Files 139 36 -103
Lines 10720 3845 -6875
Branches 215 0 -215
===========================================
- Hits 8454 3497 -4957
+ Misses 2168 348 -1820
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
|
Back in draft; missed a test case |
|
I am going to split up this PR to first to a bit of refactoring on the unit-test code. Then, on top of that, the code mod within the package itself. |
johnkerl
force-pushed
the
kerl/registration-test-neaten
branch
from
d0a2e30 to
619caf5
Compare
ryan-williams
requested changes
Mar 18, 2024
| shutil.copy(h5ad1, "/tmp/1.h5ad") | ||
| shutil.copy(h5ad2, "/tmp/2.h5ad") | ||
| shutil.copy(h5ad3, "/tmp/3.h5ad") | ||
| shutil.copy(h5ad4, "/tmp/4.h5ad") |
There was a problem hiding this comment.
Delete? Per #2285 (comment)
ryan-williams
approved these changes
Mar 18, 2024
|
Thanks @ryan-williams ! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
…2281) * [python] Neaten registration-mapping test code * [python] Fix registration path with non-standard obs/var index names * lint * code-review feedback
johnkerl
added a commit
that referenced
this pull request
Mar 18, 2024
…2281) (#2288) * [python] Neaten registration-mapping test code * [python] Fix registration path with non-standard obs/var index names * lint * code-review feedback Co-authored-by: John Kerl <[email protected]>
|
[sc-42824] |
|
This pull request has been linked to Shortcut Story #42824: [python] A registration path fails with non-standard obs/var index names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #2242
Changes: Push the kwargs all the way through the call chain
Notes for Reviewer: